Skip to content

feat: implement Indexing Agreements [Pending Audit] #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: tmigone/horizon-fixes-june
Choose a base branch
from

Conversation

matiasedgeandnode
Copy link
Contributor

@matiasedgeandnode matiasedgeandnode commented Mar 26, 2025

Copy link

openzeppelin-code bot commented Mar 26, 2025

feat: implement Indexing Agreements [Pending Audit]

Generated at commit: a7fb8758ffccad6a6f80dadcc68b12306ac0f615

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
4
0
15
39
60
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@matiasedgeandnode matiasedgeandnode force-pushed the ma/indexing-payments-003 branch 10 times, most recently from b0f7e7f to ae910c4 Compare April 2, 2025 13:41
@matiasedgeandnode matiasedgeandnode force-pushed the ma/indexing-payments-003 branch from b53a31a to d0a4db2 Compare April 3, 2025 20:06
@matiasedgeandnode matiasedgeandnode force-pushed the ma/indexing-payments-003 branch from 32252c4 to de6b7a1 Compare April 15, 2025 20:07

This comment was marked as resolved.

@matiasedgeandnode matiasedgeandnode force-pushed the ma/indexing-payments-003 branch from f4ea27a to 8776a18 Compare April 22, 2025 19:03
@matiasedgeandnode matiasedgeandnode force-pushed the ma/indexing-payments-003 branch 7 times, most recently from 753442f to 7ba3dd1 Compare May 19, 2025 16:34
@matiasedgeandnode matiasedgeandnode force-pushed the ma/indexing-payments-003 branch from 65f7f1d to ef651a6 Compare May 20, 2025 18:32
@matiasedgeandnode matiasedgeandnode force-pushed the ma/indexing-payments-003 branch from ef651a6 to aac9682 Compare May 30, 2025 18:29
@matiasedgeandnode matiasedgeandnode force-pushed the ma/indexing-payments-003 branch from 5ebb424 to 7dee19f Compare June 5, 2025 16:29
@matiasedgeandnode

This comment was marked as resolved.

@matiasedgeandnode matiasedgeandnode force-pushed the ma/indexing-payments-003 branch from 6765c56 to f0d158f Compare June 6, 2025 17:33
@matiasedgeandnode
Copy link
Contributor Author

ok, NatSpec added, pnpm lint:sol:natspec reporting same warnings as in horizon

@matiasedgeandnode matiasedgeandnode force-pushed the ma/indexing-payments-003 branch from f33e23d to 11a49fe Compare June 9, 2025 13:24
@matiasedgeandnode matiasedgeandnode changed the base branch from horizon to tmigone/horizon-fixes-june June 9, 2025 17:51
Copy link
Member

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with two small comments and pending audit)

@matiasedgeandnode matiasedgeandnode force-pushed the ma/indexing-payments-003 branch from ba64efd to 23f1436 Compare June 11, 2025 15:44
@matiasedgeandnode matiasedgeandnode changed the title feat: implement Indexing Agreements feat: implement Indexing Agreements [Pending Audit] Jun 11, 2025
@matiasedgeandnode matiasedgeandnode marked this pull request as ready for review June 11, 2025 15:52
@matiasedgeandnode matiasedgeandnode force-pushed the ma/indexing-payments-003 branch from 23f1436 to a7fb875 Compare June 11, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants