-
Notifications
You must be signed in to change notification settings - Fork 156
feat: implement Indexing Agreements [Pending Audit] #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matiasedgeandnode
wants to merge
1
commit into
tmigone/horizon-fixes-june
Choose a base branch
from
ma/indexing-payments-003
base: tmigone/horizon-fixes-june
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: implement Indexing Agreements [Pending Audit] #1134
matiasedgeandnode
wants to merge
1
commit into
tmigone/horizon-fixes-june
from
ma/indexing-payments-003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: implement Indexing Agreements [Pending Audit]
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
b0f7e7f
to
ae910c4
Compare
b53a31a
to
d0a4db2
Compare
32252c4
to
de6b7a1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
f4ea27a
to
8776a18
Compare
753442f
to
7ba3dd1
Compare
65f7f1d
to
ef651a6
Compare
pcarranzav
reviewed
May 21, 2025
packages/subgraph-service/contracts/libraries/IndexingAgreement.sol
Outdated
Show resolved
Hide resolved
packages/horizon/contracts/data-service/utilities/ProvisionManager.sol
Outdated
Show resolved
Hide resolved
pcarranzav
reviewed
May 21, 2025
packages/horizon/contracts/payments/collectors/RecurringCollector.sol
Outdated
Show resolved
Hide resolved
packages/horizon/contracts/payments/collectors/RecurringCollector.sol
Outdated
Show resolved
Hide resolved
packages/horizon/contracts/payments/collectors/RecurringCollector.sol
Outdated
Show resolved
Hide resolved
packages/horizon/contracts/payments/collectors/RecurringCollector.sol
Outdated
Show resolved
Hide resolved
packages/horizon/contracts/payments/collectors/RecurringCollector.sol
Outdated
Show resolved
Hide resolved
packages/horizon/contracts/payments/collectors/RecurringCollector.sol
Outdated
Show resolved
Hide resolved
pcarranzav
reviewed
May 22, 2025
packages/subgraph-service/contracts/libraries/UnsafeDecoder.sol
Outdated
Show resolved
Hide resolved
packages/subgraph-service/contracts/libraries/IndexingAgreement.sol
Outdated
Show resolved
Hide resolved
ef651a6
to
aac9682
Compare
tmigone
reviewed
Jun 4, 2025
tmigone
reviewed
Jun 4, 2025
tmigone
reviewed
Jun 4, 2025
tmigone
reviewed
Jun 4, 2025
tmigone
reviewed
Jun 4, 2025
packages/subgraph-service/contracts/libraries/IndexingAgreement.sol
Outdated
Show resolved
Hide resolved
tmigone
reviewed
Jun 4, 2025
pcarranzav
reviewed
Jun 4, 2025
packages/horizon/contracts/payments/collectors/RecurringCollector.sol
Outdated
Show resolved
Hide resolved
packages/subgraph-service/contracts/libraries/UnsafeDecoder.sol
Outdated
Show resolved
Hide resolved
tmigone
reviewed
Jun 5, 2025
tmigone
reviewed
Jun 5, 2025
packages/subgraph-service/contracts/libraries/IndexingAgreement.sol
Outdated
Show resolved
Hide resolved
tmigone
reviewed
Jun 5, 2025
packages/subgraph-service/contracts/libraries/IndexingAgreement.sol
Outdated
Show resolved
Hide resolved
tmigone
reviewed
Jun 5, 2025
tmigone
reviewed
Jun 5, 2025
tmigone
reviewed
Jun 5, 2025
tmigone
reviewed
Jun 5, 2025
packages/horizon/contracts/payments/collectors/RecurringCollector.sol
Outdated
Show resolved
Hide resolved
tmigone
reviewed
Jun 5, 2025
tmigone
reviewed
Jun 5, 2025
5ebb424
to
7dee19f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
6765c56
to
f0d158f
Compare
ok, NatSpec added, |
f33e23d
to
11a49fe
Compare
pcarranzav
reviewed
Jun 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with two small comments and pending audit)
packages/horizon/contracts/payments/collectors/RecurringCollector.sol
Outdated
Show resolved
Hide resolved
tmigone
reviewed
Jun 10, 2025
packages/subgraph-service/contracts/libraries/IndexingAgreement.sol
Outdated
Show resolved
Hide resolved
tmigone
reviewed
Jun 10, 2025
ba64efd
to
23f1436
Compare
23f1436
to
a7fb875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional reading: Indexing Payments technical specification v0.1